Fix/false positive app err logs #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit filters the false positive app errors by getting the StderrPipe of the cmd and using a *bufio.Scanner to read, filter and print the logs of the apps.
This commit adds info logs to app start and stopped detailed state. We add the new detailed state AppDetailedStatusStopped to every app on shutdown. The app_state is also moved from package launcher to package appserver to get around the cyclic dependency so that we can use actual Detailed status instead of strings in Proc in the package appserver.
|
Linux and Windows are OK, but I get |
mrpalide
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?yes
Fixes #1264
Changes:
How to test this PR:
./skywire-visor -c skywire-config.jsonsudo ./skywire-visor -c skywire-config.json